Merge pull request #614 from biolink/kltm-patch-1

Update qc.py
biolink · Feb 19, 2022 · bdd2e82 · bdd2e82
2 parents 3492474 + ffc8e49
commit bdd2e82
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ontobio/io/qc.py b/ontobio/io/qc.py
@@ -343,7 +343,7 @@ def test(self, annotation: association.GoAssociation, config: assocparser.AssocP
 class GoRule16(GoRule):
 
     def __init__(self):
-        super().__init__("GORULE:0000016", "All IC annotations should include a GO ID in the \"With/From\" column", FailMode.HARD)
+        super().__init__("GORULE:0000016", "All IC annotations should include a GO ID in the \"With/From\" column", FailMode.SOFT)
 
     def test(self, annotation: association.GoAssociation, config: assocparser.AssocParserConfig, group=None) -> TestResult:
         evidence = str(annotation.evidence.type)

diff --git a/tests/test_qc.py b/tests/test_qc.py
@@ -222,7 +222,7 @@ def test_go_rule_16():
     assoc = make_annotation(evidence="IC", withfrom="BLAH:12345").associations[0]
 
     test_result = qc.GoRule16().test(assoc, all_rules_config())
-    assert test_result.result_type == qc.ResultType.ERROR
+    assert test_result.result_type == qc.ResultType.WARNING
 
     # withfrom has GO term
     assoc.evidence.with_support_from = association.ConjunctiveSet.str_to_conjunctions("GO:0023456")
@@ -240,7 +240,7 @@ def test_go_rule_16():
     assoc.evidence.with_support_from = []
 
     test_result = qc.GoRule16().test(assoc, all_rules_config())
-    assert test_result.result_type == qc.ResultType.ERROR
+    assert test_result.result_type == qc.ResultType.WARNING
 
     # Not IC
     assoc.evidence.type = Curie.from_str(iea_eco)