Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homolog object is missing taxon key #112

Open
selewis opened this issue Oct 21, 2017 · 5 comments
Open

Homolog object is missing taxon key #112

selewis opened this issue Oct 21, 2017 · 5 comments

Comments

@selewis
Copy link
Contributor

selewis commented Oct 21, 2017

For this query
http://localhost:8888/api/bioentity/gene/HGNC:11593/homologs/?homology_type=O&fetch_objects=false

The JSON returned is this and clearly the taxon for zfin is missing :
{'id': '11d97a53-bf91-477e-89e2-340f94e8264e', 'subject': {'id': 'NCBIGene:347853', 'label': 'TBX10', 'taxon': {'id': 'NCBITaxon:9606', 'label': 'Homo sapiens'}}, 'object': {'id': 'ZFIN:ZDB-GENE-121228-1', 'label': 'tbx10'}, 'negated': False, 'relation': {'id': 'RO:HOM0000017', 'label': 'in orthology relationship with'}, 'publications': [{'id': 'PMID:22915831'}], 'provided_by': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'evidence': ['MONARCH:ba21515e9db29392', 'PMID:22915831', 'ECO:0000031', 'NCBIGene:347853', 'ZFIN:ZDB-GENE-121228-1'], 'evidence_graph': {'nodes': [{'id': 'ECO:0000031', 'lbl': 'protein BLAST evidence used in manual assertion', 'meta': {}}, {'id': 'MONARCH:ba21515e9db29392', 'lbl': None, 'meta': {}}, {'id': 'ZFIN:ZDB-GENE-121228-1', 'lbl': 'tbx10', 'meta': {}}, {'id': 'PMID:22915831', 'lbl': 'Ahn et al; Evolution of the Tbx6/16 Subfamily Genes in Vertebrates: Insights from Zebrafish; Mol. Biol. Evol.; 2012; 29(12); 3959-3983', 'meta': {}}, {'id': 'NCBIGene:347853', 'lbl': 'TBX10', 'meta': {}}], 'edges': [{'sub': 'MONARCH:ba21515e9db29392', 'obj': 'PMID:22915831', 'pred': 'dc:source', 'meta': {'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['Source'], 'equivalentOriginalNodeTarget': ['http://zfin.org/ZDB-PUB-120830-8']}}, {'sub': 'ZFIN:ZDB-GENE-121228-1', 'obj': 'NCBIGene:347853', 'pred': 'RO:HOM0000017', 'meta': {'owlType': ['Annotation'], 'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['in orthology relationship with']}}, {'sub': 'MONARCH:ba21515e9db29392', 'obj': 'NCBIGene:347853', 'pred': 'OBAN:association_has_object', 'meta': {'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['association has object']}}, {'sub': 'MONARCH:ba21515e9db29392', 'obj': 'PMID:22915831', 'pred': 'dc:source', 'meta': {'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['Source']}}, {'sub': 'MONARCH:ba21515e9db29392', 'obj': 'ZFIN:ZDB-GENE-121228-1', 'pred': 'OBAN:association_has_subject', 'meta': {'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['association has subject']}}, {'sub': 'MONARCH:ba21515e9db29392', 'obj': 'ECO:0000031', 'pred': 'RO:0002558', 'meta': {'isDefinedBy': ['https://data.monarchinitiative.org/ttl/zfin.ttl'], 'lbl': ['has evidence']}}], 'meta': {'query': 'monarch:cypher/gene-homology.yaml'}}}

@selewis
Copy link
Contributor Author

selewis commented Oct 21, 2017

For that same query there were also zfin hits with the taxon keys, but the values are null

@cmungall
Copy link
Contributor

Do you mean to query using type O? The main panther types are P, O and LDO. We should perhaps make the O query also query LDO, but now it's the asserted link.

I'm not sure if this related, but querying using O appears to be broken right now... I get an internal server error when I try your query on the public server. It's always a good idea to check both to be sure it's not something introduced in local code.

I'm seeing the taxon IDs in the public server too

@cmungall
Copy link
Contributor

I can't reproduce this

@selewis
Copy link
Contributor Author

selewis commented Oct 21, 2017

I just tried it and now the taxon is there, but the values are null. Better, but not ideal
(index 14 of hits)

Use of O was deliberate. We discussed and that was the choice at the time.

@cmungall
Copy link
Contributor

cmungall commented Oct 22, 2017

I just tried it and now the taxon is there, but the values are null

Which values? I tried

https://api.monarchinitiative.org/api/bioentity/gene/HGNC:11593/homologs/?homology_type=O&fetch_objects=false

looks like taxon information and the gene id and label is there.

there is an annoying issue where it reports null values for inapplicable fields or unpopulated fields, but that has nothing to do with this ticket?

Better, but not ideal (index 14 of hits)

Not sure what you mean

Use of O was deliberate. We discussed and that was the choice at the time.

I don't understand why you would not want LDO too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants