Gocamgen reporting changes and deleting gpad_extensions_mapper #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes out the GPAD parser GO rules report in
gpad2gocams
along with adding anerrors
container for passing model translation error data (e.g. Couldn't get regulates relation from logical definition of a term) to the translation report.Also, completely dropped
gpad_extensions_mapper.py
and refactored the remaining (though already commented out) gocamgen code that was referencing it. Removing the riggedis_cool
conditional caused the enormous tab-shift as seen in the diff.@kltm According to @dougli1sqrd, the code I just removed was initially causing some problems in testing of ontobio's static analysis tools. Do you have a way for us to test this is fixed now? Eric pasted the error results of some
isolate following_rules
command?