Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gocamgen reporting changes and deleting gpad_extensions_mapper #542

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

dustine32
Copy link
Collaborator

This writes out the GPAD parser GO rules report in gpad2gocams along with adding an errors container for passing model translation error data (e.g. Couldn't get regulates relation from logical definition of a term) to the translation report.

Also, completely dropped gpad_extensions_mapper.py and refactored the remaining (though already commented out) gocamgen code that was referencing it. Removing the rigged is_cool conditional caused the enormous tab-shift as seen in the diff.

@kltm According to @dougli1sqrd, the code I just removed was initially causing some problems in testing of ontobio's static analysis tools. Do you have a way for us to test this is fixed now? Eric pasted the error results of some isolate following_rules command?

@kltm
Copy link
Member

kltm commented Mar 23, 2021

@dustine32 For this merge, I'll defer to @dougli1sqrd .

I wouldn't worry too much about the static code testing for the moment, but you can see some of the commands and where this is coming from over here: https://github.com/berkeleybop/bbops/issues/6

@dougli1sqrd dougli1sqrd merged commit 0ec3aa6 into master Mar 24, 2021
@dougli1sqrd dougli1sqrd deleted the gocamgen branch March 24, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants