Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #2108 #670

Merged

Conversation

mugitty
Copy link
Collaborator

@mugitty mugitty commented Mar 26, 2024

Updated hard fail to warning

@mugitty mugitty requested a review from kltm March 26, 2024 17:25
@kltm
Copy link
Member

kltm commented Mar 26, 2024

I'll wait on review until tests pass.

@mugitty mugitty requested a review from dustine32 March 27, 2024 20:53
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass now and monarch issue bypassed.

@mugitty mugitty merged commit 74d6c54 into master Mar 27, 2024
5 checks passed
@mugitty mugitty deleted the go-site-2108-gorule-0000063-is-a-warning-instead-of-hard-fail branch May 6, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants