fix wrong states on PE output pins (and SD-card failure on restart) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output register status buffer was initialized fix to {0xff,0xff}
although the output registers were set to {0x00,0x00}.
That buffer is used by Port_Write() to determine the values of the
bits for the other pins. So those get set to 1 (high).
Since the peripheral power on the Espuino 4-layer mini PCB is switched
on by setting a pin on the PCA9555 low, that power is first turned on
(by Port_Init()), then turned off (by the Port_Write() call in
AudioPlayer_Init()) and then turned on again (by Power_PeripheralOn()).
That caused a 12.5 millisecond disruption of the external 3.3V which
some SD-cards don't like.
|
Tested with Lolin D32 pro /SD-MMC /blue PCB and Mini4Layer PCB, everything works as expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output register status buffer was initialized fix to {0xff,0xff} although the output registers were set to {0x00,0x00}. That buffer is used by Port_Write() to determine the values of the bits for the other pins. So those get set to 1 (high).
Since the peripheral power on the Espuino 4-layer mini PCB is switched on by setting a pin on the PCA9555 low, that power is first turned on (by Port_Init()), then turned off (by the Port_Write() call in AudioPlayer_Init()) and then turned on again (by Power_PeripheralOn()). That caused a 12.5 millisecond disruption of the external 3.3V which some SD-cards don't like.