Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest on graphing fails with pyvis==0.3 #200

Closed
himoto opened this issue Oct 27, 2022 · 6 comments
Closed

pytest on graphing fails with pyvis==0.3 #200

himoto opened this issue Oct 27, 2022 · 6 comments
Assignees
Labels
bug Something isn't working graph Graph visualization

Comments

@himoto
Copy link
Contributor

himoto commented Oct 27, 2022

Hi @formersbach,
I noticed that pytest on graphing fails with the latest stable pyvis (version 0.3.0).
When I restrict pyvis version via pyvis>=0.2.1,<0.3, we don't see any errors.
Some updates in pyvis from v0.2 to v0.3 might affect the graph generation.

@himoto himoto added bug Something isn't working graph Graph visualization labels Oct 27, 2022
himoto pushed a commit that referenced this issue Oct 29, 2022
@formersbach
Copy link
Contributor

Hey @himoto ! I'll take a look.

@himoto
Copy link
Contributor Author

himoto commented Nov 10, 2022

Thanks @formersbach! There is no rush.

@formersbach
Copy link
Contributor

Hey @himoto !
It is indeed a change in pyvis that leads to the error. To be specific this commit.
Pyvis now generates some temporary files but is unable to remove them since they're not generated at the expected location.
Should I attempt fixing it or do we just require pyvis v0.2?

@himoto
Copy link
Contributor Author

himoto commented Nov 23, 2022

Hi @formersbach,thanks for finding out the cause of the error.
I have added a constraint that pyvis version must be smaller than 0.3 (#201, see below)and it works perfectly fine.
So far we can go with this but if we get a new problem regarding graph visualization, we will need to fix it to be compatible with the latest pyvis.

"pyvis>=0.2.1,<0.3",

@formersbach
Copy link
Contributor

Sounds good!
Shall we then close this issue?

@himoto
Copy link
Contributor Author

himoto commented Nov 23, 2022

Closed

@himoto himoto closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph Graph visualization
Projects
None yet
Development

No branches or pull requests

2 participants