Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer graphing from BioMass to Text2Model #177

Merged
merged 8 commits into from
Aug 24, 2022

Conversation

formersbach
Copy link
Contributor

This pull request transfers the graphing capabilities from the BioMass level to the Text2Model level.

@formersbach
Copy link
Contributor Author

Hey @himoto
Please review whether I correctly changed model_object.py especially careful!

Copy link
Contributor

@himoto himoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, looks so nice to me!
Before merging into master, I have a small request.
Please refer to my comments.

biomass/construction/text2model.py Outdated Show resolved Hide resolved
@himoto
Copy link
Contributor

himoto commented Aug 23, 2022

Hi @formersbach, can you please update .pre-commit-config.yaml file?

language_version: python3.7

In line 13, please bump python version from 3.7 to 3.8 in order to support walrus operator (:=).

@himoto
Copy link
Contributor

himoto commented Aug 23, 2022

Question:
Does your updates affect test_graph.py?
If yes, please also update the test code to be compatible with the latest graphing method.

@himoto
Copy link
Contributor

himoto commented Aug 24, 2022

Thanks @formersbach! I will soon merge these changes into master.

@himoto himoto merged commit 3638c71 into master Aug 24, 2022
@himoto himoto deleted the graph_Text2Model_integration branch August 24, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants