Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish nightlies as pre-releases #145

Merged
merged 13 commits into from
Feb 18, 2024
Merged

feat: publish nightlies as pre-releases #145

merged 13 commits into from
Feb 18, 2024

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Feb 17, 2024

Summary

This PR changes the way we publish nightly (pre-release) versions.

Description

Up until now, we published two distinct extension (biomejs.biome & biomejs.biome-nightly). This PR leverages VS Code's pre-release system to ship both stable and pre-releases under the same name, using a pre-release flag where appropriate.

Versions

The nightly versions are released with a version number based on the date and time.

  • {year}.{month}.{day}{hour}, e.g. 2024.2.1719

This way, they don't clash with the semver-like version used for the stable releases.

Todo

  • Ask the VS Code team to deprecate biomejs.biome-nightly

Related Issue

This PR closes #137

@nhedger nhedger marked this pull request as ready for review February 17, 2024 18:27
@nhedger nhedger marked this pull request as draft February 17, 2024 18:27
@nhedger nhedger marked this pull request as ready for review February 17, 2024 18:34
@nhedger nhedger merged commit 471c5ef into main Feb 18, 2024
8 checks passed
@nhedger nhedger deleted the feat/nightlies branch February 18, 2024 08:31
@Malix-off
Copy link
Contributor

Is there any ETA on the pre-release release?

@Malix-off
Copy link
Contributor

Malix-off commented Feb 18, 2024

By the way, it's possible to ask the VS code team to deprecate biomejs.biome-nightly with the added explicit metadata that it's been replaced with biomejs.biome

@nhedger
Copy link
Member Author

nhedger commented Feb 18, 2024

Is there any ETA on the pre-release release?

Already published

@nhedger
Copy link
Member Author

nhedger commented Feb 18, 2024

By the way, it's possible to ask the VS code team to deprecate biomejs.biome-nightly with the added explicit metadata that it's been replaced with biomejs.biome

Yep. Already asked them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Publish nightlies as pre-releases instead of separate extension
2 participants