fix(biome_graphql_parser): prevent empty interface list in implement …

…clause (#2776)
biomejs · May 10, 2024 · 49cace8 · 49cace8
1 parent 5088667
commit 49cace8
Show file tree

Hide file tree

Showing 5 changed files with 726 additions and 623 deletions.
diff --git a/crates/biome_graphql_parser/src/parser/definitions/interface.rs b/crates/biome_graphql_parser/src/parser/definitions/interface.rs
@@ -12,6 +12,7 @@ use biome_graphql_syntax::{
     T,
 };
 use biome_parser::parse_lists::ParseNodeList;
+use biome_parser::prelude::TokenSource;
 use biome_parser::{
     parse_lists::ParseSeparatedList, parse_recovery::ParseRecovery, parsed_syntax::ParsedSyntax,
     prelude::ParsedSyntax::*, Parser,
@@ -53,12 +54,16 @@ pub(super) fn parse_implements_interface(p: &mut GraphqlParser) -> ParsedSyntax
 
     p.bump(T![implements]);
 
-    if p.at(T![&]) {
-        p.bump(T![&]);
-    }
+    // & is optional
+    p.eat(T![&]);
 
+    let position = p.source().position();
     ImplementsInterfaceList.parse_list(p);
 
+    if position == p.source().position() {
+        p.error(expected_named_type(p, p.cur_range()));
+    }
+
     Present(m.complete(p, GRAPHQL_IMPLEMENTS_INTERFACES))
 }
 

diff --git a/crates/biome_graphql_parser/tests/graphql_test_suite/err/definitions/interface.graphql b/crates/biome_graphql_parser/tests/graphql_test_suite/err/definitions/interface.graphql
@@ -44,6 +44,8 @@ inter Person
 
 interface Person implemets Character
 
+interface Person implements &
+
 interface Person @
 
 interface Person implents Character @