feat(linter): allow to call expect inside waitFor (#2521)

CHANGELOG.md

@@ -44,6 +44,19 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
   ```
   Contributed by @ematipico
 
+#### Enhancements
+
+- The rule `noMisplacedAssertions` now considers valid calling `expect` inside `waitFor`:
+  ```js
+  import { waitFor } from '@testing-library/react';
+
+  await waitFor(() => {
+    expect(111).toBe(222);
+  });
+  ```
+  Contributed by @ematipico
+
+
 ### Parser
 
 

crates/biome_js_analyze/src/lint/nursery/no_misplaced_assertion.rs

@@ -83,6 +83,13 @@ declare_rule! {
     /// })
     /// ```
     ///
+    /// ```js
+    /// import { waitFor } from '@testing-library/react';
+    /// await waitFor(() => {
+    ///   expect(111).toBe(222);
+    /// });
+    /// ```
+    ///
     pub NoMisplacedAssertion {
         version: "1.6.4",
         name: "noMisplacedAssertion",

crates/biome_js_analyze/tests/specs/nursery/noMisplacedAssertion/valid.js

@@ -1,13 +1,17 @@
 describe("msg", () => {
-    it("msg", () => {
-        expect("something").toBeTrue()
-    })
+	it("msg", () => {
+		expect("something").toBeTrue()
+	})
 })
 
 test("something", () => {
-    expect("something").toBeTrue()
+	expect("something").toBeTrue()
 })
 
 Deno.test("something", () => {
-    expect("something").toBeTrue()
-})
+	expect("something").toBeTrue()
+})
+
+await waitFor(() => {
+	expect(111).toBe(222);
+});

crates/biome_js_analyze/tests/specs/nursery/noMisplacedAssertion/valid.js.snap

@@ -5,16 +5,21 @@ expression: valid.js
 # Input
 ```jsx
 describe("msg", () => {
-    it("msg", () => {
-        expect("something").toBeTrue()
-    })
+	it("msg", () => {
+		expect("something").toBeTrue()
+	})
 })
 
 test("something", () => {
-    expect("something").toBeTrue()
+	expect("something").toBeTrue()
 })
 
 Deno.test("something", () => {
-    expect("something").toBeTrue()
+	expect("something").toBeTrue()
 })
+
+await waitFor(() => {
+	expect(111).toBe(222);
+});
+
 ```

crates/biome_js_syntax/src/expr_ext.rs

@@ -1086,9 +1086,10 @@ impl AnyJsExpression {
     }
 
     /// Checks whether the current function call is:
-    /// - `it`
-    /// - `test`
-    /// - `Deno.test`
+    /// - `it`: many libraries such as Node.js, Mocha, Jest, etc.
+    /// - `test`: many libraries such as Node.js, bun, etc.
+    /// - [`Deno.test`](https://docs.deno.com/runtime/manual/basics/testing/)
+    /// - [`waitFor`](https://testing-library.com/docs/dom-testing-library/api-async/#waitfor)
     pub fn contains_it_call(&self) -> bool {
         let mut members = CalleeNamesIterator::new(self.clone());
 
@@ -1100,7 +1101,7 @@ impl AnyJsExpression {
         let second = rev.next().map(|t| t.text());
 
         match first {
-            Some("test" | "it") => true,
+            Some("test" | "it" | "waitFor") => true,
             Some("Deno") => matches!(second, Some("test")),
             _ => false,
         }