Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Commented single instruction in a control flow body should be consistently formatted #1173

Closed
1 task done
Conaclos opened this issue Dec 13, 2023 · 2 comments · Fixed by #1655
Closed
1 task done

📝 Commented single instruction in a control flow body should be consistently formatted #1173

Conaclos opened this issue Dec 13, 2023 · 2 comments · Fixed by #1655
Assignees
@mdm317
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Dec 13, 2023 •
edited
Loading

Environment information

Configuration

Default configuration

Description

Playground link

this leads to non-idempotent formatting

I suggest the following formatting (and thus to slightly diverge from Prettier for the first one):

label1: for (;;) continue label1; /* comment */

label1: for (;;) continue label1; // comment

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Dec 13, 2023
@mdm317
Copy link
Contributor

mdm317 commented Jan 11, 2024

May I try to solve this issue?

@Conaclos
Copy link
Member Author

Of course :) All yours!

@mdm317 mdm317 mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdm317 mdm317

Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js_formatter): fix comment with single instruction within a control flow body mdm317/biome
2 participants
@Conaclos @mdm317