Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Implement keyframe-declaration-no-important #2536

Closed
Tracked by #2511
togami2864 opened this issue Apr 20, 2024 · 5 comments
Closed
Tracked by #2511

📎 Implement keyframe-declaration-no-important #2536

togami2864 opened this issue Apr 20, 2024 · 5 comments
Assignees
@isnakode
Labels
A-Linter Area: linter good first issue Good for newcomers L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@togami2864
Copy link
Contributor

togami2864 commented Apr 20, 2024 •
edited
Loading

Description

Implement keyframe-declaration-no-important

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
@togami2864 togami2864 mentioned this issue Apr 20, 2024
Open
34 tasks
@togami2864 togami2864 added good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-CSS Language: CSS labels Apr 20, 2024
@isnakode
Copy link
Contributor

i'm interested

@ematipico
Copy link
Member

@isnakode Remember to follow the rule pillars when writing the diagnostics: https://biomejs.dev/linter/#rule-pillars

@isnakode
Copy link
Contributor

should i name the lint noImportantKeyframeDeclaration or noImportantInKeyframeDeclaration? or u have better suggestion?

@ematipico
Copy link
Member

noImportantInKeyframe?

@isnakode isnakode mentioned this issue Apr 21, 2024
Merged
@togami2864
Copy link
Contributor Author

close #2542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isnakode isnakode

Labels
A-Linter Area: linter good first issue Good for newcomers L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ematipico @togami2864 @isnakode