feat(biome_css_analyze): noImportantInKeyframe #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ty <62130798+togami2864@users.noreply.github.com>
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2542 will degrade performances by 7.2%Comparing Summary
Benchmarks breakdown
|
togami2864
approved these changes
Apr 21, 2024
crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs
Outdated
Show resolved
Hide resolved
…rame.rs Co-authored-by: ty <62130798+togami2864@users.noreply.github.com>
ematipico
reviewed
Apr 21, 2024
crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_important_in_keyframe.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
ematipico
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR adds lint support for removing !important declaration within keyframe block #2536
Test Plan
spec test