Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/correctness/noUndeclaredVariables should ignore TsGlobalDeclaration #2932

Closed
ash0080 opened this issue May 21, 2024 · 7 comments
Closed
Labels
S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Please update the playground link, it seems not illustrate the current issue.

@ematipico ematipico added the S-Needs repro Status: needs a reproduction label May 21, 2024
@ash0080
Copy link
Author

ash0080 commented May 22, 2024

Please update the playground link, it seems not illustrate the current issue.

It seems the playground server was experiencing an issue, but it appears to be accessible now.

@Conaclos
Copy link
Member

I see the following code in the playground:

export default {
  flowProps: 'a'
} satisfies FlowConfig

I don't understand how this code is related to the current issue.

@ash0080
Copy link
Author

ash0080 commented May 24, 2024

I see the following code in the playground:

export default {
  flowProps: 'a'
} satisfies FlowConfig

I don't understand how this code is related to the current issue.

check the main.ts

declare global {
    interface FlowConfig {
        flowProps: string
    }
}

In this case, where I have defined a global type instead of a global variable, the current implementation of Biome does not support this. The key difference from the previous issue (#1651) is that I am now working with a global type definition, rather than a global variable.

@ematipico ematipico added S-Bug-confirmed Status: report has been confirmed as a valid bug and removed S-Needs repro Status: needs a reproduction labels May 30, 2024
@ematipico
Copy link
Member

I can't replicate the issue in the playground.

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@ematipico
Copy link
Member

@ash0080 sorry, the playground doesn't show the error.

Please create a repository at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

3 participants