🐛 biome ci . --colors=off outputting colors

[alechartung]

Environment information

CLI:
  Version:                      1.8.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "foot"
  JS_RUNTIME_VERSION:           "v22.3.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.8.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

1. run biome ci . --colors=off
2. "Checked 1493 files in 262ms. No fixes needed." text is purple
   

Expected result

Output shouldn't have colors.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

That's intended, we enforce the colours in the ci command. Is there a reason why you want to turn off the colours in CI?

[alechartung]

I'm capturing the output of the CI job to put into a comment, and this is what I'm getting now:

[ematipico]

I see, thank you for the explanation.

I believe the fix should still force the colours, but only if the user hasn't provided them via CLI. If the user provides it, we should use it

[Sec-ant]

@ematipico Is this possibly the reason why the github reporter doesn't work? #3148

[ematipico]

I don't know, it could be