📎 Implement lint/noUselessLoneBlockStatements - eslint/no-lone-block

[Conaclos]

Description

no-lone-blocks.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

[ematipico]

I think, in our case, the word "lone" can be dropped. I suggest noUselessBlock

[Conaclos]

I think, in our case, the word "lone" can be dropped. I suggest noUselessBlock

Not sure, because the rule concerns only "lone" block statements, i.e. block statements that are not attached to a if, else, while, function, ...

EDIT: The rule prohibits lone blocks that don't include any variables declaration.

Example of incorrect code:

{
  f();
}

{}

Example of correct ode:

{
  let x = 1;
}

// This is not a lone block
if (cond) {}

[ematipico]

Thank you for clarifying! I would still remove "statement" from the word :) it's not beginner friendly

[emab]

Hey there. I've been using Biome so would love to contribute. I'm fairly new to Rust, but willing to give this a go if you're ok with that?

[ematipico]

Go ahead @emab , feel free to use this issue to ask any question, or even a draft pr

[emab]

Great! Thank you.

[emab]

Hi @ematipico, please can I check if I'm on the right path?

emab@62e85fe

[emab]

I wasn't sure how to check for strict mode in one of my functions...

[Conaclos]

Please open a PR so that we can add comments :)

[emab]

Opened, link above!

[emab]

@Conaclos may I ask how I can have multiple valid / invalid test files? I want to include ones which are a module (by adding exports {}) and ones which are not in order to properly test the detection of functions in block statements.

[Conaclos]

@emab simply add other files, for example invalidXXXX.js.

For esm use js or ts extension. For script file (non-strict mode) you can use cjs extension.

[emab]

@emab simply add other files, for example invalidXXXX.js.

For esm use js or ts extension. For script file (non-strict mode) you can use cjs extension.

Brilliant thank you, have updated the PR.