Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搸 Implement nursery/noStaticElementInteractions - eslint-plugin-jsx-a11y/no-static-element-interactions #527

Open
nissy-dev opened this issue Oct 15, 2023 · 9 comments
Assignees
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@nissy-dev
Copy link
Member

nissy-dev commented Oct 15, 2023

Description

Implement no-static-element-interactions
This rule is one of the recommended rules in eslint-plugin-jsx-a11y.

Want to contribute? Lets we know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

@nissy-dev nissy-dev added L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter good first issue Good for newcomers labels Oct 15, 2023
@andrewangelle
Copy link
Contributor

Hello! I'd like to pick this up if possible.

@ematipico
Copy link
Member

@andrewangelle the issue is yours

@ematipico
Copy link
Member

This issue is still available

@Conaclos Conaclos changed the title 馃搸 Implement lint/noStaticElementInteractions - eslint-plugin-jsx-a11y/no-static-element-interactions 馃搸 Implement nursery/noStaticElementInteractions - eslint-plugin-jsx-a11y/no-static-element-interactions Mar 14, 2024
@seitarof
Copy link
Contributor

@ematipico
Can I work on this?
I'm enhancing a11y in the product I'm developing, so this rule might be useful!

@ryo-ebata
Copy link

@ematipico
Hello.
Regarding this issue, can I take charge of it?
I have already started development in the local environment.

@ryo-ebata
Copy link

ryo-ebata commented May 17, 2024

This is a simple question, and I have no other intention...

Why is the title of this issue "nursery" and not "a11y"?
I would have thought it should be "a11y" since the purpose is to make it explicit as an interactive element by having the appropriate role attribute, etc. set.

The appropriate role attribute helps visualize the focus, like a focus indicator.

@ematipico
Copy link
Member

It seems we don't explain this anywhere. I will try to add it to the contribution guide.

When we implement new rules, we add them inside the group nursery. Here's an explanation of the group

Since nursery rules are under development and free from the semantic versioning, we can make as many PR we want to fix them and make them better. Once we decide that a nursery rule is "stable", we promote them to a group that fits it. (in this case it will be a11y group)

@ematipico ematipico assigned ryo-ebata and unassigned seitarof May 18, 2024
@ryo-ebata
Copy link

ryo-ebata commented May 18, 2024

@ematipico
Thanks for the detailed explanation!
I'll add the rules to the nursery.

@ematipico
Copy link
Member

ematipico commented May 18, 2024

@ryo-ebata please follow our contribution guide, it has all the information you need, even the answer to your previous question:

https://github.com/biomejs/biome/blob/main/crates%2Fbiome_analyze%2FCONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants