fix(lsp): correctly infer file source from un-named files #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Project
ematipico
commented
Jan 3, 2024
Comment on lines
+272
to
+285
| let file_source = match params.parse.file_source(params.path) { | ||
| Ok(file_source) => file_source, | ||
| Err(_) => { | ||
| if let Some(file_source) = params.language.as_js_file_source() { | ||
| file_source | ||
| } else { | ||
| return LintResults { | ||
| errors: 0, | ||
| diagnostics: vec![], | ||
| skipped_diagnostics: 0, | ||
| }; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
This is the new change and the bulk of the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1394
Newly created files weren't correctly processed when calling the analyzer from the LSP. The reason why this wasn't working anymore is because:
JsFileSource, which tells what kind of JavaScript file we are processing (JS, JSX, TS, etc.). The analyser changed to default to zero diagnostics in case we couldn't compute theJsFileSourcefrom the file path. This broke the LSP when the LSP analyzed untitled files.Untitled files are saved and updated by using the actions
textDocument/didOpenandtextDocument/didChange, that's where we keep track of their language.Now when pulling diagnostics and computing
JsFileSource, we:Test Plan
Added a new test