fix(js_formatter): fix invalid formatting of long arrow function for AsNeeded arrow parens #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Cool |
fireairforce
commented
Feb 28, 2024
| @@ -214,7 +214,7 @@ pub(crate) fn should_hug_function_parameters( | |||
| ) -> FormatResult<bool> { | |||
| /// Returns true if the first parameter should be forced onto the same line as the `(` and `)` parentheses. | |||
| /// See the `[ParameterLayout::Hug] documentation. | |||
| fn hug_formal_parameter(parameter: &self::AnyJsFormalParameter) -> FormatResult<bool> { | |||
| fn hug_formal_parameter(parameter: &self::AnyJsFormalParameter, from_arrow_function: bool, has_parentheses: bool) -> FormatResult<bool> { | |||
There was a problem hiding this comment.
I just add a simple judge here to deal this case.
fireairforce
force-pushed
the
fix-#1905
branch
from
d5f5114
to
fab646a
Compare
CodSpeed Performance ReportMerging #1934 will improve performances by 8.52%Comparing Summary
Benchmarks breakdown
|
ematipico
requested changes
Feb 28, 2024
There was a problem hiding this comment.
This fix has caused our compatibility ratio with prettier. I am going to block it in advance and see if there's a better fix.
My initial advice is to look at Prettier's logic/behaviour.
The second advice is to understand if we really want to accept this change, because if so, we need to diverge.
crates/biome_js_formatter/tests/specs/prettier/typescript/generic/arrow-return-type.ts.snap
Outdated
Show resolved
Hide resolved
fireairforce
force-pushed
the
fix-#1905
branch
2 times, most recently
from
ee02ecc
to
2cf766f
Compare
|
I updated this pr, PTAL for free~ @ematipico |
fireairforce
force-pushed
the
fix-#1905
branch
2 times, most recently
from
98198f9
to
6a44f6c
Compare
ematipico
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
That's more like it! Great contribution, thank you @fireairforce!
|
it seems the ci block? i think it has nothing to do with this PR |
…AsNeeded arrow parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1905
Test Plan