fix: concurrency deadlock #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
arendjr
approved these changes
Mar 6, 2024
anonrig
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To fix the deadlock, I created two functions get/set to manage the
IndexSet<DocumentFileSource>list. By doing so, we reduce the "window" of when the lock is actually owned by a thread. In the functionget_parse, we were actually trying to lock the same resource multiple times without releasing them.By using two small functions, the lock is released when the scope of the function ends, making it safer.
Test Plan
I run our internal
pnpm checkmultiple time and now there's not deadlock