Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(use-number-namespace.md): fix typo #2155

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

arienshibani
Copy link
Contributor

Summary

Test Plan

@github-actions github-actions bot added the A-Website Area: website label Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 1029493
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66145d919e89d9000851acd0
😎 Deploy Preview https://deploy-preview-2155--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant
Copy link
Member

Sec-ant commented Mar 21, 2024

Hello, the doc is auto generated from the source, so you should update the source and then generate the doc with the command just gen-lint. But in this simple case I think you can just manually fix the typo here as well:

/// The rule doesn't report the globals `isFinite` and `isNan` because they have a slightly different behabior to their corresponding `Number`'s properties `Number.isFinite` and `Number.isNan`.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 8, 2024
Copy link

codspeed-hq bot commented Apr 8, 2024

CodSpeed Performance Report

Merging #2155 will improve performances by 12.58%

Comparing arienshibani:patch-1 (1029493) with main (a8726d0)

Summary

⚡ 2 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark main arienshibani:patch-1 Change
big5-added.json[cached] 2.3 ms 2.1 ms +7.67%
db.json[cached] 75.5 ms 67 ms +12.58%

@nhedger nhedger changed the title chore(use-number-namespace.md): ✏️ Fix typo: behabior -> behavior chore(use-number-namespace.md): fix typo Apr 8, 2024
@nhedger nhedger merged commit 26eda3a into biomejs:main Apr 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants