Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): do not cache nightly channel #2167

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 22, 2024

Summary

Warmup strategy doesn't work well with rust nightly channels because we will then always save two copies of toolchains in our runner, one is the stable from the warmup branch and the other is the nightly. Therefore it can eat up the space quickly.

So I disabled the cache for nightly channel toolchains. It's nightly, so I think it will be fine.

Test Plan

Jobs requiring nightly channel toolchains shouldn't fail.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 5129ac0
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65fdcecd437ee500088a35a8
😎 Deploy Preview https://deploy-preview-2167--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant merged commit 091854f into biomejs:main Mar 22, 2024
4 of 5 checks passed
@Sec-ant Sec-ant deleted the ci/nightly-channel branch March 22, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant