Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): revert wasm-pack dev mode change #2170

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 23, 2024

Summary

The problematic commit: https://github.com/biomejs/biome/pull/2166/files#diff-16233821c7a54e3f17c4c0e1ddff269adc1dc764c80887e10e242fecbaa1efcd

I was hoping to accelerate the building process but this will trigger a build error. So revert the change.

Test Plan

CI should pass.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit c899a65
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65fe782a9ce329000828986f
😎 Deploy Preview https://deploy-preview-2170--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant merged commit 95974a1 into biomejs:main Mar 23, 2024
4 of 5 checks passed
@Sec-ant Sec-ant deleted the ci/fix-wasm-pack branch March 23, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant