Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_formatter): CssImportAtRule formatting #2180

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

Implement formatting for CssImportAtRule.

Test Plan

cargo test

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS labels Mar 24, 2024
Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 4efd91a
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6600ae474e933300086ec06d
😎 Deploy Preview https://deploy-preview-2180--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 24, 2024

CodSpeed Performance Report

Merging #2180 will degrade performances by 14.19%

⚠️ No base runs were found

Falling back to comparing feat/import-at-rule-formatting (4efd91a) with main (70bce5a)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/import-at-rule-formatting Change
eucjp.json[uncached] 4.9 ms 5.7 ms -14.19%

@denbezrukov denbezrukov force-pushed the feat/import-at-rule-formatting branch from 48572d4 to 4efd91a Compare March 24, 2024 22:50
@denbezrukov denbezrukov merged commit 3fdf1ee into main Mar 25, 2024
18 of 19 checks passed
@denbezrukov denbezrukov deleted the feat/import-at-rule-formatting branch March 25, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant