-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codegen): new lint rule generation #2187
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
let _binding = ctx.query(); | ||
Some(()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default template should emit diagnostic.
I think here we don't need to implement the rule because this is a template, so commenting out valid cases. Developers will delete the template before starting the dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Please revert the changes in the list, then we can merge it
crates/biome_analyze/CONTRIBUTING.md
Outdated
1. The `Ast` query type allows you to query the AST of a program. | ||
1. The `State` type doesn't have to be used, so it can be considered optional. However, it has to be defined as `type State = ()`. | ||
1. Implement the `run` function: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional, can you revert it please? If you list all numbers to 1.
they will rendered automatically in order. This means you just need to add another 1
in case you're adding a new step in middle.
It's really convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't know that. I restore the change!
Summary
In
generate_new_lintrule.rs
, this PR fixesnode.range()
becausereference
isn't definedsrc/lint/nursery
Test Plan
Executed
just new-js-lintrule ruleName
without fail