Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: derive Copy on LoggingKind and LoggingLevel #2207

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Mar 25, 2024

Summary

Deriving Copy makes it so that types can be copied without needing to explicitly call .clone(). This makes the type a little easier to work with, and also indicates there is no hidden performance cost to copying it. As such, it should only be derived on types that don't require allocations. For enums where the variants have no custom fields, deriving Copy is generally safe, as long as no future variants with custom fields are anticipated either.

See also: https://doc.rust-lang.org/std/marker/trait.Copy.html#when-should-my-type-be-copy

Test Plan

CI should remain green.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 889821e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6601dadbc1392900084a5998
😎 Deploy Preview https://deploy-preview-2207--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-CLI Area: CLI label Mar 25, 2024
@arendjr arendjr merged commit 600e035 into biomejs:main Mar 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants