Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_analyzer): binary expression utils #2250

Merged

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 31, 2024

Summary

This PR fixes an issue where an operator with no spaces around in a binary expression can break the js analyzer. Specifically when rule lint/suspicious/noMisrefactoredShorthandAssign is enabled.

Closes #2243

Test Plan

Added a test case.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 31, 2024
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 46c963b
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66097489f754f8000848958f
😎 Deploy Preview https://deploy-preview-2250--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 31, 2024

CodSpeed Performance Report

Merging #2250 will degrade performances by 18.81%

⚠️ No base runs were found

Falling back to comparing Sec-ant:fix/js-analyzer-binary-expression-utils (46c963b) with main (d98c549)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Sec-ant:fix/js-analyzer-binary-expression-utils Change
big5-added.json[uncached] 2.7 ms 3.4 ms -18.81%
db.json[uncached] 87.1 ms 79.7 ms +9.22%

@Sec-ant Sec-ant merged commit c88a5d5 into biomejs:main Mar 31, 2024
16 of 17 checks passed
@Sec-ant Sec-ant deleted the fix/js-analyzer-binary-expression-utils branch March 31, 2024 16:09
@Sec-ant Sec-ant mentioned this pull request Apr 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 biom crashed
2 participants