Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): basic parsing element list with context bump #2272

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR implements the basic parsing of a list of elements. The parsing of this list is inspired to the JSX parsing, where all trivia is parsed as a HtmlContent.

The lexer also adds some initial lexing of comments, although I haven't implemented any logic because I encountered some lexing issue that I prefer to solve after this PR lands.

Test Plan

I added new test cases

@github-actions github-actions bot added the A-Tooling Area: internal tools label Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 15f64cd
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/660bd688b5018900085d5a4d
😎 Deploy Preview https://deploy-preview-2272--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented Apr 2, 2024

CodSpeed Performance Report

Merging #2272 will degrade performances by 7.28%

Comparing feat/html-parser-element-list (15f64cd) with main (4719012)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/html-parser-element-list Change
router.ts[cached] 10.7 ms 11.6 ms -7.28%

@ematipico ematipico merged commit a6f5f0e into main Apr 2, 2024
18 of 19 checks passed
@ematipico ematipico deleted the feat/html-parser-element-list branch April 2, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants