-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js_analyzer): add graphics-symbol role #2294
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #2294 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
This PR will make <svg aria-hidden><rect /></svg>
This error can be catched by |
Summary
Adds the
graphics-symbol
ARIA role which should be replaceable withimg
for valid SVG ARIA roles (and is more descriptive for icons). Updates possible usage from current recommendations from an article from University at Melbourne.jsx-a11y
had this same problem at one point, but I think that’s been fixed already and that currently supports these roles for SVGs, so this should just bring parity with that (or at least, that’s the intention)Also adds
graphics-document
andgraphics-object
roles for completeness…but I might have messed something up? Open to feedback if something’s in the wrong place 🙂Test Plan