Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: speed up wasm-pack profiling build #2494

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Apr 17, 2024

Summary

Disable wasm-opt when running pnpm build:wasm-dev.

Context: biomejs/website#22 (comment)

Test Plan

wasm-opt is skipped for profiling builds.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 5299ef1
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661fa0740a75660008ea5db7
😎 Deploy Preview https://deploy-preview-2494--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico
Copy link
Member

Damn, where did you find this gem? I couldn't find anything on the website 😓

@Sec-ant
Copy link
Contributor Author

Sec-ant commented Apr 17, 2024

Damn, where did you find this gem? I couldn't find anything on the website 😓

This is documented here: https://rustwasm.github.io/docs/wasm-pack/cargo-toml-configuration.html But I must admit it is very well-hidden.

@Sec-ant Sec-ant merged commit aaf42ee into main Apr 17, 2024
16 checks passed
@Sec-ant Sec-ant deleted the chore/wasm-pack-profile branch April 17, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants