ci: add a workflow for linting pr titles #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
Apr 18, 2024
Comment on lines
58
to
60
| ignoreLabels: | | ||
| bot | ||
| ignore-semantic-pull-request |
There was a problem hiding this comment.
I don't think we use these labels internally
Comment on lines
24
to
34
| # Default: https://github.com/commitizen/conventional-commit-types | ||
| types: | | ||
| fix | ||
| feat | ||
| chore | ||
| ci | ||
| docs | ||
| refactor | ||
| release | ||
| test | ||
| revert |
There was a problem hiding this comment.
Can you align the types with what we have in the contribution guide? https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#commit-messages
ematipico
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a workflow for linting pr titles. It uses amannn/action-semantic-pull-request, used by some repositories (Electron · Vite · Excalidraw · Apache · Vercel · Microsoft · Firebase · AWS).
This is definition of each part (from amannn/action-semantic-pull-request).
I only added some types.
No scope and subject pattern for now, but we can define scopes for consistency. In lint area, we have some random scopes for example
lint,lint/ruleName,analyzer.Valid title
Invalid title
Test Plan
Tested on my forked repository : unvalley#2