feat(biome_css_analyze): noDuplicateSelectorsKeyframeBlock #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2534 will improve performances by 17.64%Comparing Summary
Benchmarks breakdown
|
togami2864
reviewed
Apr 20, 2024
crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
5
| @keyframes foo { from {} from {}} | ||
|
|
||
| @keyframes foo { from {} FROM {}} | ||
|
|
||
| @keyframes foo { 0% {} 0% {}} |
There was a problem hiding this comment.
Co-authored-by: ty <62130798+togami2864@users.noreply.github.com>
ematipico
approved these changes
Apr 20, 2024
| rule_category!(), | ||
| node.range(), | ||
| markup! { | ||
| "Unexpected duplicate selector: "<Emphasis>{node.text()}</Emphasis> |
There was a problem hiding this comment.
@togami2864 can you please follow up on this rule? Let's remember that we want to follow the rule pillars: https://biomejs.dev/linter/#rule-pillars
This rule doesn't explain why two duplicated selectors are wrong.
unvalley
changed the title
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR adds lint support to remove duplicate selector in keyframes block #2523
Test Plan
spec test