Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snippet): should emit only one diagnostic #2650

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Apr 29, 2024

Summary

A snippet must emit only ONE diagnostic.

- When adding _invalid_ snippets in the `### Invalid` section, you must use the `expect_diagnostic` code block property. We use this property to generate a diagnostic and attach it to the snippet. A snippet **must emit only ONE diagnostic**.

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 29, 2024
@Sec-ant Sec-ant merged commit 47489cc into main Apr 29, 2024
14 checks passed
@Sec-ant Sec-ant deleted the fix/lint-doc-snippet branch April 29, 2024 17:38
Copy link

codspeed-hq bot commented Apr 29, 2024

CodSpeed Performance Report

Merging #2650 will not alter performance

Comparing fix/lint-doc-snippet (e8ab31e) with main (8f9c14a)

Summary

✅ 90 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant