feat(linter): implement NoUnmatchableAnbSelector
#2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2706 will not alter performanceComparing Summary
|
ematipico
approved these changes
May 4, 2024
| } | ||
| } | ||
|
|
||
| fn is_within_not_pseudo_class(node: &AnyCssPseudoClassNth) -> bool { |
There was a problem hiding this comment.
It might be worth documenting a bit this function
| .note(markup! { | ||
| "Avoid using An+B selectors that always evaluate to 0." | ||
| }).note(markup! { | ||
| "For more details, see "<Hyperlink href="https://www.w3.org/TR/css-syntax-3/#anb-microsyntax">"this document"</Hyperlink>"." |
There was a problem hiding this comment.
Suggested change
| "For more details, see "<Hyperlink href="https://www.w3.org/TR/css-syntax-3/#anb-microsyntax">"this document"</Hyperlink>"." | |
| "For more details, see "<Hyperlink href="https://www.w3.org/TR/css-syntax-3/#anb-microsyntax">"the official spec for An+B selectors"</Hyperlink>"." |
togami2864
force-pushed
the
feat/noUnmatchableAnbSelector
branch
from
eea2601
to
6b6f3ca
Compare
togami2864
changed the title
NoUnmatchableAnbSelectorNoUnmatchableAnbSelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #2524
Test Plan
added tests and snapshots