Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noDuplicateAtImportRules): correctly handle both single- and double quotes #2707

Merged
merged 1 commit into from
May 4, 2024

Conversation

DerTimonius
Copy link
Contributor

Summary

While checking different rules, I noticed that I forgot to check for a specific case when implementing the noDuplicateAtImportRules rule.

@import "a.css";
@import 'a.css';

This should show an error, but didn't.

This PR fixes this small bug and also adds a test for this scenario

Test Plan

Added a new test to validate the change.

@github-actions github-actions bot added the L-CSS Language: CSS label May 4, 2024
Copy link

codspeed-hq bot commented May 4, 2024

CodSpeed Performance Report

Merging #2707 will not alter performance

Comparing DerTimonius:fix/no-duplicate-at-imports (18cf153) with main (1b63093)

Summary

✅ 86 untouched benchmarks

@ematipico ematipico merged commit 293084b into biomejs:main May 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants