refactor(parse/css): change fields in CssParserSettings to Option

[dyc3]

Summary

This changes the CSS parser options to use Option<bool> for better semantics when dealing with default values and fallbacks.

basically the same change as #3272

Test Plan

Ci should pass

[codspeed-hq]

CodSpeed Performance Report

Merging #3273 will not alter performance

_{Comparing dyc3:06-23-refactor_parse_css_change_fields_in_cssparseroptions_and_cssparsersettings_to_option_ (101a3e4) with main (7935235)}

Summary

✅ 90 untouched benchmarks

[ematipico]

It seems we made some mistake somewhere (very difficult to see from the PR). The CSS linter should be disabled by default, so the failed test is legit and we should not update it

[Sec-ant]

This is addressed in a better way

The problem is here:

biome/crates/biome_service/src/settings.rs

Lines 248 to 252 in 7935235

	/// Whether the formatter is disabled for CSS files
	pub fn css_formatter_disabled(&self) -> bool {
	let enabled = self.languages.css.formatter.enabled.as_ref();
	enabled == Some(&false)
	}

It should be changed to:

 /// Whether the formatter is disabled for CSS files 
 pub fn css_formatter_disabled(&self) -> bool { 
     let enabled = self.languages.css.formatter.enabled.as_ref();
     // TODO: Change me when CSS formatter is enabled by default.
     enabled != Some(&true) 
 } 

And the default here doesn't work because CssFormatterSettings is not None when running the biome format command, it's a Some with all the fields set to None:

biome/crates/biome_service/src/file_handlers/css.rs

Lines 53 to 64 in 7935235

	impl Default for CssFormatterSettings {
	fn default() -> Self {
	Self {
	enabled: Some(false),
	indent_style: Default::default(),
	indent_width: Default::default(),
	line_ending: Default::default(),
	line_width: Default::default(),
	quote_style: Default::default(),
	}
	}
	}

I didn't check how and why it worked before. The logic is a little complicated.

---

Maybe we should do the same change for css_linter_disabled to disable the linter by default when running biome lint command.

biome/crates/biome_service/src/settings.rs

Lines 266 to 270 in 7935235

	/// Whether the linter is disabled for CSS files
	pub fn css_linter_disabled(&self) -> bool {
	let enabled = self.languages.css.linter.enabled.as_ref();
	enabled == Some(&false)
	}

[dyc3]

Basically, the Default impl for PartialCssFormatter has enabled: None, which makes it fall back to the default for formatting config, which is enabled: true.

IMO a better fix would be to impl Default for PartialCssFormatter, but it appears the Partial macro implements it automatically.

[ematipico]

Ah shoot, I didn't see that coming

[Sec-ant]

Thanks! I wonder if you plan to refactor the JsParserSettings?

[dyc3]

I can open an issue for refactoring JsParserSettings, but I want to focus on editorconfig support so I don't think I'll get to it right away.

Edit: I've opened #3297 for this