refactor(codegen): generate most functions on LanguageKind with a macro
#3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
07-08-refactor_codegen_generate_most_functions_on_languagekind_with_a_macro
branch
from
0c94a24
to
6be41ea
Compare
dyc3
force-pushed
the
07-08-refactor_codegen_generate_most_functions_on_languagekind_with_a_macro
branch
from
6be41ea
to
f59511f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors how most of the functions on
LanguageKindare defined to be generated from a macro. The purpose is to make it less tedious, and reduce the potential for merge conflicts when implementing new languages. Since we'll likely be implementing a few new languages for HTML-ish language support (#1726), I figured this would be useful. Ideally, simply adding an entry toenum LanguageKindshould be enough, but doing that requires a proc macro.Test Plan
Everything compiles, and inlining the macros with rust analyzer produces the same output as before the refactor