Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade toolchain to 1.72.0 #66

Closed
wants to merge 5 commits into from

Conversation

ematipico
Copy link
Member

Summary

Updates the toolchain to rust 1.72.0:

  • removed atty, because now rust ships is_terminal, making atty obsolete;
  • semantic model now uses Rc instead Arc. clippy found the issue, saying that Arc must now implement Sync and Send. Rc is used instead (we are not in a multi-thread context, Mutex is not needed);
  • the rest is just clippy and format changes

Test Plan

Current CI should pass

@ematipico ematipico temporarily deployed to Website deployment August 25, 2023 10:07 — with GitHub Actions Inactive
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages labels Aug 25, 2023
@ematipico
Copy link
Member Author

!bench_parser
!bench_formatter
!bench_analyzer

@ematipico ematipico temporarily deployed to Website deployment August 25, 2023 10:16 — with GitHub Actions Inactive
@ematipico ematipico temporarily deployed to Website deployment August 25, 2023 11:06 — with GitHub Actions Inactive
@github-actions github-actions bot added the A-Website Area: website label Aug 25, 2023
@ematipico ematipico temporarily deployed to Website deployment August 25, 2023 12:18 — with GitHub Actions Inactive
@ematipico ematipico temporarily deployed to Website deployment August 25, 2023 12:45 — with GitHub Actions Inactive
@ematipico ematipico closed this Aug 25, 2023
@ematipico ematipico deleted the chore/upgrade-rust-1.72.0 branch August 25, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools A-Website Area: website L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant