New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
challenge(formatter): add lineEnding
option
#786
Conversation
Is there a specific reason why the I'm currently working on a project where we use Biome, and we're having problems with (what I assume has to be) the line-endings. We faced a similar problem when using prettier/eslint in a different project, and the best solution turned out to use the Edit: |
Some of us had reservations about options that aren't predictable, such as this In particular for line ending, some of us thought that users should use |
As I usually prefere to keep things like this predictable myself, I can understand to some degree. I just also aknowledge the need for "grey areas" once in a while I think. 😅 So this means it was a conscious decision to leave out "auto" when adding the lineEnding option, and that there is no point in creating an issue for it? 😇 |
You could create a GitHub discussion and build a case for the option! Why you need it, explain your use case, etc |
Summary
The Prettier challenge requires us to add all Prettier options relevant when formatting JS
This PR adds a
lineEnding
option, with the following values:lf
crlf
cr
Test Plan
Added one new test,
line-ending.js