two editorial fixes (#40) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added contribution from other repo * working * working * working * Update toolbox.adoc Updated text, added specific number of PAIs to be created in the test (as opposed to having this in individual toolbox tests for consistency) * Update toolbox.adoc Editorial corrections * Update toolbox.adoc Updated the pass/fail criteria based on @The-Fiona comments * Updates to Eye Toolbox Added new test list (with sensor applicability). Modified test sets to add number of species types to be produced (including all variants). Removed "Other" section as this is now in main toolbox overview. * added to toolbox.adoc * Migrated vein to adoc Created attack subfolder, moved all attacks there. Renamed "general.md" to "vein_PADtesting.adoc" No content changes (other than changing Variations to "None") * migrated face to adoc Moved from TXT files to adoc format, not content change. Moved files into attacks folder to fit with eye (and PR for vein) * migrated remaining tests to adoc I migrated the remaining docs to adoc. I copied the attack potential table to all the tests (without changes except in tests 5 becasue those are largely blank so I put in "?"). I moved the remaining files to make it follow the other toolbox updates. I moved the inventory document to adoc as well. * IND to FUN Edited ATE_IND.1 to ATE_FUN.1 * Update toolbox.adoc undo the ATE_IND to ATE_FUN back to ATE_IND * remove TODO line Remove the TODO line based on discussion on 5/16 to leave it as transactions for vendor flexibility * Single subject update Based on the 5/30 call this proposed change is to specify the number of subjects to be used in the creation of PAI. * changed date changed date * fixed internal reference link Similar problem with reference links as in PP-Module * Clarification about AVA_VAN Based on comments from Mary Baisch, this update attempts to clarify that that toolbox is not intended for AVA_VAN but can be used as the basis for those tests with modifications that the evaluator may decide to make. Also found a misspelling, and added the :icons: font in the header (though I removed the section that specifically needed it). * Revert "Clarification about AVA_VAN" This reverts commit 05e5e51. * Initial update for PR1 Based on comments by Mary Baisch this is intended to further clarify how the toolbox could be used as a basis for the creation of AVA_VAN tests while not being written for that purpose. Also fixed a misspelling and added :icons: font line to the header. * Toolbox Template Example This is in response to #18 about related to having a standardized template for a toolbox. There are 4 files in the main folder (here BIO is used to mark the modality, so this should be EYE, FACE, FINGER, etc): PAD Testing - the description of anything specific to this modality that needs to be documented (in addition to the toolbox overview) along with an introduction to the toolbox. List - a table list of all the tests and any applicability notes (like these are only relevant with certain types of sensors or other considerations) Inventory - a list of the inventory that is used in the test, things like paper, printers, camera, the things used to make the PAI References - external references for any of the attacks (a master list) Within the main folder there would then be subfoldlers marked with XX_<attack category>_attacks. The XX would be numbering for increasing difficulty (i.e. the lowest level PAI, simplest to create would be 01, the most difficult test would be the top number). The <attack category> would be some sort of title that would provide some clarity as to what the tests will be used as a source for the PAI. Within each folder then, you would have the files names XX_YY_attack where the XX matches the folder number and YY is the test number. The List table should match out all the numbers. While I don't have it in here, there is a (Vx) listing for some of the tests, this is when there is a number of variants for the specific test available (so a test with a V1 and V2 would have 2 variants in addition to the "base" test). This could be handled in another way though. This used the eye tests to fill out the template, but I didn't modify any of the files. * Revert "Toolbox Template Example" This reverts commit 8a48e39. * Revert "Revert "Toolbox Template Example"" This reverts commit aba98fa. * Revert "Revert "Revert "Toolbox Template Example""" This reverts commit 6e2d608. * Revert "Revert "Revert "Revert "Toolbox Template Example"""" This reverts commit 448dbb8. * Revert "Revert "Revert "Revert "Revert "Toolbox Template Example""""" This reverts commit 645dcfa. * Toolbox Template Example This is in response to #18 about related to having a standardized template for a toolbox. There are 4 files in the main folder (here BIO is used to mark the modality, so this should be EYE, FACE, FINGER, etc): PAD Testing - the description of anything specific to this modality that needs to be documented (in addition to the toolbox overview) along with an introduction to the toolbox. List - a table list of all the tests and any applicability notes (like these are only relevant with certain types of sensors or other considerations) Inventory - a list of the inventory that is used in the test, things like paper, printers, camera, the things used to make the PAI References - external references for any of the attacks (a master list) Within the main folder there would then be subfoldlers marked with XX_<attack category>_attacks. The XX would be numbering for increasing difficulty (i.e. the lowest level PAI, simplest to create would be 01, the most difficult test would be the top number). The <attack category> would be some sort of title that would provide some clarity as to what the tests will be used as a source for the PAI. Within each folder then, you would have the files names XX_YY_attack where the XX matches the folder number and YY is the test number. The List table should match out all the numbers. While I don't have it in here, there is a (Vx) listing for some of the tests, this is when there is a number of variants for the specific test available (so a test with a V1 and V2 would have 2 variants in addition to the "base" test). This could be handled in another way though. This used the eye tests to fill out the template, but I didn't modify any of the files. * update to 3 subjects Update to three subjects as noted in #17 * Updated to match new toolbox template This is an update to match the new toolbox template. No changes were made to the attacks themselves. Previous attack set 01 has been removed as the scan and reprint tests have been removed from Face as well. * Eye Attack Potential update Added Attack Potential tables for each attack and each species type for each attack. All calculations show under the 13 limit. * Update for clarification This is to close #22 as agreed on the 12/5 call. * Test procedure update This is to close #23 related to clarifying the overall testing description. The table was also updated to follow a more "standard" format. The PP name was updated to match the current. * first commit * Update toolbox.adoc * Update toolbox.adoc * Update toolbox.adoc * Update toolbox.adoc * Brian toolbox edits My suggested edits to the changes. I have edited some text (moved a few things around), did some grammar checking, and edited the tables. * editorial update by Kai I updated the overview to fix some inconsistency or mistakes * research paper authority One line update to strengthen the use of research papers * 1st commit * 2nd commit * 3rd commit * 1st commit * Update and rename 2D-face_attack_1-2.adoc to 2D-face_attack_1_1.adoc * Update 2D_Face_Toolbox_overview.adoc * Update 2D-face_attack_1_1.adoc * Update 2D_Face_Toolbox_Tool_Inventory.adoc * Update and rename references.adoc to 2D_Face_Toolbox_References.adoc * Update 2D-face_attack_1_1.adoc * Update and rename 2D-face_attack_1-3.adoc to 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_1.adoc * Update and rename 2D-face_attack_2-1.adoc to 2D-face_attack_1_3.adoc * Update 2D-face_attack_1_1.adoc * Update 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_1.adoc * Update 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_3.adoc * Update and rename 2D-face_attack_2-2.adoc to 2D-face_attack_2-1.adoc * Delete attack_1-1.adoc * Update and rename 2D-face_attack_2-3.adoc to 2D-face_attack_2-2.adoc * Update and rename 2D-face_attack_2-4.adoc to 2D-face_attack_2-3.adoc * Delete 2D-face_attack_3-1.adoc * Delete 2D-face_attack_3-2.adoc * Delete 2D-face_attack_3-3.adoc * Delete 2D-face_attack_4-1.adoc * Delete 2D-face_attack_4-2.adoc * Delete 2D-face_attack_5-1.adoc * Delete 2D-face_attack_5-2.adoc * Update 2D_Face_Toolbox_overview.adoc * Update 2D_Face_Toolbox_Tool_Inventory.adoc * Update 2D_Face_Toolbox_Tool_Inventory.adoc * Rename 2D-face_attack_2-1.adoc to 2D-face_attack_2_1.adoc * Rename 2D-face_attack_2-2.adoc to 2D-face_attack_2_2.adoc * Rename 2D-face_attack_2-3.adoc to 2D-face_attack_2_3.adoc * Create 2D_Face_Verification_List.adoc * Updated based on NK comments * Update 2D-face_attack_1_3.adoc * Update 2D-face_attack_1_1.adoc * Update 2D-face_attack_1_2.adoc * Update 2D_Face_Verification_List.adoc * Delete 2D-face_attack_2_1.adoc * Delete 2D-face_attack_2_2.adoc * Delete 2D-face_attack_2_3.adoc * Update toolbox.adoc * Update toolbox.adoc * Update toolbox overview Change the text as suggested by @woodbe in #32 * Update 2D-face_attack_1_1.adoc * Update 2D-face_attack_1_2.adoc * Update 2D-face_attack_1_3.adoc * editorial fixes * 3D face toolbox overview * move file * Delete 3D_Face_Toolbox_overview.adoc * editorial fixes * Update 3D_Face_Toolbox_overview.adoc * final update * editorial update * editorial update * Update 2D-face_attack_1_1.adoc * editorial update * Create 3D-face_attack_1_1.adoc * Update 2D_Face_Toolbox_Tool_Inventory.adoc * Create 3D_Face_Toolbox_Tool_Inventory.adoc * Create 3D-face_attack_3.adoc * Create 3D_Face_Verification_List.adoc * Create 3D_Face_Toolbox_References.adoc * Updates from Brian I made several updates here. Most focused on language in the reading to be a little clearer. Some table adjustments were also made to present the tables a little better. * Update 3D_Face_Toolbox_Tool_Inventory.adoc * Editorial update for proposed release This is editorial related to the biometricITC/cPP-biometrics#266 to try to polish the Toolbox for release at the same time. I added a revision history and changed SD to BIOSD. I also edited the title to match with the rest of the docs. * Update toolbox.adoc update based on @n-kai comment to move this to the Toolbox from the SD. * Removal of old toolboxes Current face and eye toolboxes have been moved to their own repositories, so these are being deleted. * Removal of old files These files are being removed as out of date * Deleting template for toolbox This template is now out of date. A new one may need to be created, but probably not right now. * Update toolbox.adoc Updates based on MITRE's review. * Updates for public release These are focused on updating the dates and versions for all the documents in preparation of public release on May 11, 2020. * Update toolbox.adoc Added doctype for proper formatting of PDF output * Move of vein to own repository moved all vein to separate repository * two editorial fixes Fix the errors in table Co-authored-by: nils <nt@konfidas.de> Co-authored-by: Brian Wood <be.wood@samsung.com> Co-authored-by: The-Fiona <37903201+The-Fiona@users.noreply.github.com> Co-authored-by: ccolin318 <56977088+ccolin318@users.noreply.github.com>
|
This looks like a lot of changes due to how the PR was created, but is actually just 2 editorial changes. |
|
Shouldn't you keep Variations (line 78 before modification) into the 2nd modification? |
Merged
|
This has been approved by the iTC membership (results with email addresses removed). |
n-kai
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the errors in table