New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set `random-shuffle=false` by default #16

Closed

biona001 opened this issue Jun 25, 2024 · 0 comments

Owner

biona001 commented Jun 25, 2024

Consider turning this option off due to the following:

In our simulations, we never used this option, and FDR was always under control.
In our flagship paper, the method section did not mention randomly permutate Z-scores and its knockoffs.

biona001 mentioned this issue

Roadmap for v0.2.0 release #18

Closed

5 tasks

biona001 added a commit that referenced this issue


          turn off random shuffling (#16)

c4a66f7

biona001 added a commit that referenced this issue


          turn off random shuffling (#16)

a4054ca

biona001 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment