Merge pull request heroku#56 from heroku/pipefail

use pipefail to force exit when `npm install` fails.
manuphatak · Oct 16, 2013 · b43097f · b43097f
2 parents 5bc02d2 + b82b5bf
commit b43097f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/bin/compile b/bin/compile
@@ -1,10 +1,8 @@
 #!/usr/bin/env bash
 
-# fail fast
-set -e
-
-# enable debugging
-# set -x
+set -e            # fail fast
+set -o pipefail   # don't ignore piped exit codes
+# set -x          # enable debugging
 
 # Configure directories
 build_dir=$1

diff --git a/bin/test b/bin/test
@@ -66,6 +66,11 @@ testProfileCreated() {
   assertCapturedSuccess
 }
 
+testInvalidDependency() {
+  compile "invalid-dependency"
+  assertCapturedError 1 "not in the npm registry"
+}
+
 testNodeModulesCached() {
   cache=$(mktmpdir)
   compile "caching" $cache