-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merops IDs are not resolving to the correct page #439
Comments
Okay so we can take the following steps:
As each of these have separate entity types and URI format strings, I still disagree about having a combine prefix for all of them. The only case where this makes sense is if there's also an "omni"-URI format string |
Merged
cthoyt
added a commit
that referenced
this issue
Jul 5, 2022
@cmungall alright problem solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are two entries for this one database in bioregistry; the split was made by identifiers.org:
This is split doesn't make any sense as I'll explain below
The example IDs:
https://bioregistry.io/reference/merops.family:S1
https://bioregistry.io/reference/merops.inhibitor:I31.952
Don't resolve to individual pages. They just take me to the top level https://www.ebi.ac.uk/merops/ -- this is presumably because bioregistry has a sanger URL, and the redirect doesn't preserve the query parameters.
I think if merops.sanger.ac.uk ==> ebi.ac.uk/merops/ then these particular entries will be fixed, but there are still major issues
If identifiers.org is going to split merops, I don't think the current division makes sense
MEROPS is actually divided into peptidases and inhibitors. Within each of these categories there are divisions into
Example peptidase classification:
The leaf nodes typically equate to individual genes or proteins, but there are also groupings e.g. https://www.ebi.ac.uk/merops/cgi-bin/pepsum?id=C01.UNA
Example inhibitor classification:
If we want to subdivide the merops namespace in order to support resolution, then we should use clan/family/entry -- the same URLs are used regardless of whether we are talking about peptidases or inhibitors.
E.g.
I don't have a better term than than "entry" - I don't think "protein" is good as the "pepsum" entries are sometimes themselves subfamilies. We could just go with their own nomenclature of "pep"
Note that if we did split like this, this would be something of a hard fork from identifiers.org, unless we can coordinate with them to make the same change.
IMO the whole decision by identifiers.org to split databases into sub-namespaces is really problematic but I have commented on this elsewhere.
I believe merops isn't updated any more so I'm not sure how high a priority this all is.
FWIW, this is the entry we have for GO:
Note that unlike identifiers.org we didn't partition the namespace into two, it's all one. But this only works for the leaf nodes in merops. We made a different category error from identifiers.org. But using our scheme we would simply add the new types under the general MEROPS entry.
The text was updated successfully, but these errors were encountered: