Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regular expression pattern for wikipedia.en #794

Closed
cmungall opened this issue Apr 3, 2023 · 0 comments · Fixed by #795
Closed

Update regular expression pattern for wikipedia.en #794

cmungall opened this issue Apr 3, 2023 · 0 comments · Fixed by #795
Assignees
@cthoyt
Labels
Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@cmungall
Copy link
Contributor

cmungall commented Apr 3, 2023

Prefix

wikipedia.en

New Regular Expression Pattern

^\S+$

Explanation

I am assuming the wikipedia entry is for any page in wikipedia.

If so then it's too restrictive, e.g.

https://en.wikipedia.org/wiki/Pharyngeal_pouch_(embryology)

Note that the regex I propose is broader than what W3C CURIE allows. We may want to restrict this to be only valid CURIEs and force pct-encoding, but that general issue seems unresolved, e.g #648

Contributor ORCID

0000-0002-6601-2165
@cmungall cmungall added Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries labels Apr 3, 2023
@cthoyt cthoyt mentioned this issue Apr 4, 2023
Merged
cthoyt added a commit that referenced this issue Apr 4, 2023
@cthoyt @cmungall
Update pattern for wikipedia.en (#795)
f1e2673 
Closes #794

---------

Co-authored-by: Chris Mungall <cjm@berkeleybop.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthoyt cthoyt

Labels
Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pattern for wikipedia.en biopragmatics/bioregistry
2 participants
@cmungall @cthoyt