Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new provider to Reactome record for Pathway Viewer #1086

Merged
merged 5 commits into from Apr 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2024

Closes #1085

@github-actions github-actions bot added New Used in combination with prefix, metaprefix, or collection for new entries Prefix labels Apr 9, 2024
@cthoyt cthoyt changed the title Add prefix: reactome.pathway Add new provider to Reactome record for Pathway Viewer Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.44%. Comparing base (9da7ad2) to head (0c410fa).
Report is 24 commits behind head on main.

❗ Current head 0c410fa differs from pull request most recent head 797b2bd. Consider uploading reports for the commit 797b2bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   40.55%   40.44%   -0.12%     
==========================================
  Files         150      150              
  Lines        8341     8340       -1     
  Branches     1929     1637     -292     
==========================================
- Hits         3383     3373      -10     
- Misses       4754     4776      +22     
+ Partials      204      191      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt
Copy link
Member

cthoyt commented Apr 10, 2024

@sierra-moxon I just added a curation guide for providers in https://github.com/biopragmatics/bioregistry/blob/create-pull-request/patch-0178d13/docs/guides/providers.md. Can you take a look at this and tell me if it's sufficient to explain what's going on here?

@rombaum since you also recently curated some providers, your feedback would be helpful too. The goal is to get enough information in this page that someone new can read it and understand what to put where, and why

@sierra-moxon
Copy link
Contributor

Makes sense, thanks!

@cthoyt cthoyt merged commit 86eb6c1 into main Apr 11, 2024
11 checks passed
@cthoyt cthoyt deleted the create-pull-request/patch-0178d13 branch April 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reactome pathway viewer CURIE expansion support prefix
2 participants