Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix: bko #284

Merged
merged 4 commits into from Jan 12, 2022
Merged

Add prefix: bko #284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b53988
[create-pull-request] automated change
bgyori Jan 12, 2022
2cce29e
Update bioregistry.json
cthoyt Jan 12, 2022
09544df
Add contact information
cthoyt Jan 12, 2022
caa7447
Remove unnecessary banana
cthoyt Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/bioregistry/data/bioregistry.json
View file
Open in desktop
Expand Up @@ -4496,7 +4496,6 @@
}
},
"bko": {
"banana": "BKO:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still confused about this... as far as I could tell, the BKO: prefix is shown explicitly everywhere an ID appears on the provider website, as well as in the URL pattern the website uses to resolve IDs in their native ontology browser.

"comment": "This resource also uses SBO terms and resolves them, e.g., http://www.sbgnbricks.org/BKO/full/entry/all/SBO:0000177/.",
"contact": {
"email": "adrienrougny@gmail.com",
Expand Down
1 change: 1 addition & 0 deletions tests/test_identifiers_org.py
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ def test_banana(self):
identifier = bioregistry.get_example(prefix)
self.assertIsNotNone(identifier)
url = bioregistry.resolve_identifier.get_identifiers_org_iri(prefix, identifier)
self.assertIsInstance(url, str)
res = self.session.get(url, allow_redirects=False)
self.assertEqual(302, res.status_code, msg=f"failed with URL: {url}")

Expand Down