Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rdflib-endpoint for SPARQL service #780

Merged
merged 12 commits into from
Mar 24, 2023
Merged

Use rdflib-endpoint for SPARQL service #780

merged 12 commits into from
Mar 24, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Mar 23, 2023

This PR replaces the sparql endpoint generated by the curies package with @vemonet's rdflib-endpoint.

I've identified that rdflib-endpoint needs more careful parsing of headers, and is only working by accident in some cases.

cthoyt and others added 8 commits March 23, 2023 16:44
Co-Authored-By: Vincent Emonet <vincent.emonet@gmail.com>
Co-Authored-By: Vincent Emonet <vincent.emonet@gmail.com>
Co-Authored-By: Vincent Emonet <vincent.emonet@gmail.com>
Co-Authored-By: Vincent Emonet <vincent.emonet@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.05 🎉

Comparison is base (952d0bf) 39.68% compared to head (3ee6894) 39.74%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   39.68%   39.74%   +0.05%     
==========================================
  Files         132      132              
  Lines        7511     7525      +14     
  Branches     1740     1740              
==========================================
+ Hits         2981     2991      +10     
- Misses       4351     4354       +3     
- Partials      179      180       +1     
Impacted Files Coverage Δ
src/bioregistry/app/cli.py 0.00% <0.00%> (ø)
src/bioregistry/app/wsgi.py 0.00% <0.00%> (ø)
src/bioregistry/app/impl.py 75.75% <87.50%> (+1.68%) ⬆️
src/bioregistry/version.py 68.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cthoyt cthoyt marked this pull request as ready for review March 24, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants