Use libxml-ruby instead of libxml-jruby to fix JRuby test failures. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The travis-ci Gemfiles currently call for libxml-jruby; this appears not to support the same API as libxml-ruby, resulting in several tests in test/unit/bio/db/test_phyloxml.rb failing with "NameError: uninitialized constant LibXMLJRuby::XML::Parser::Options". Switching to the C libxml-ruby library allows these tests to pass under JRuby in 1.8 mode. JRuby in 1.9 mode still fails a few PhyloXML tests due to https://jira.codehaus.org/browse/JRUBY-6662.
|
It appears that this C extension route isn't going to be supported by JRuby in 1.9 mode. Let's hold off on this for now, I'll look further into alternatives. |
|
It looks like porting PhyloXML to use Nokogiri instead, and possibly repackaging it as a separate gem, will be the way to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The travis-ci Gemfiles currently call for libxml-jruby; this appears
not to support the same API as libxml-ruby, resulting in several tests
in test/unit/bio/db/test_phyloxml.rb failing with "NameError:
uninitialized constant LibXMLJRuby::XML::Parser::Options". Switching
to the C libxml-ruby library allows these tests to pass under JRuby in
1.8 mode.
JRuby in 1.9 mode still fails a few PhyloXML tests due to
https://jira.codehaus.org/browse/JRUBY-6662.