Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client always calls dev COMBINE API #3180

Closed
bilalshaikh42 opened this issue Oct 8, 2021 · 4 comments · Fixed by #3498 or #3506
Closed

Client always calls dev COMBINE API #3180

bilalshaikh42 opened this issue Oct 8, 2021 · 4 comments · Fixed by #3498 or #3506
Assignees
@jonrkarr @bilalshaikh42
Labels
bug Something isn't working
Projects
ToDo

Comments

@bilalshaikh42
Copy link
Member

i don't remember setting the configuration of the combine service to be dependent on the environment, so it must be always calling the dev deployment, even in production
@bilalshaikh42 bilalshaikh42 added the bug Something isn't working label Oct 8, 2021
@bilalshaikh42 bilalshaikh42 added this to Needs triage in ToDo Oct 14, 2021
@jonrkarr
Copy link
Member

The deployed dispatch app always calls org.

https://combine.api.biosimulations.dev is hardcoded into libs/combine/api-client/src/lib/api/simulationProjectsCOMBINEOMEXArchives.service.ts. I guess this happens because this is the first URL in the OpenAPI spec.

The configurationFactory needs to be linked to Endpoints or the generate-combine-client script can modify how configuration is passed in.

@jonrkarr jonrkarr changed the title Client always calls dev combine service Client always calls dev COMBINE API Nov 4, 2021
jonrkarr added a commit that referenced this issue Nov 4, 2021
@jonrkarr
refactor(dispatch-service): configured COMBINE API endpoint; closes #…
2bf7927 
…3180
@jonrkarr jonrkarr mentioned this issue Nov 4, 2021
Merged
@jonrkarr jonrkarr assigned jonrkarr and unassigned bilalshaikh42 Nov 4, 2021
ToDo automation moved this from Needs triage to Closed Nov 4, 2021
jonrkarr added a commit that referenced this issue Nov 4, 2021
@jonrkarr
refactor(dispatch-service): configured COMBINE API endpoint; closes #…
6425e36 
…3180
@bilalshaikh42 bilalshaikh42 self-assigned this Nov 4, 2021
@bilalshaikh42 bilalshaikh42 reopened this Nov 4, 2021
ToDo automation moved this from Closed to Needs triage Nov 4, 2021
@bilalshaikh42
Copy link
Member Author

bilalshaikh42 commented Nov 4, 2021 •
edited

The associated commit may not work since config service is provided async. This will always cause the env to be null, leading to the dev basepath selected by default.

@bilalshaikh42
Copy link
Member Author

I am working on this in #3495

@jonrkarr
Copy link
Member

jonrkarr commented Nov 4, 2021

I saw that. In practice, it seemed to work fine. The client library has to be changed to accommodate that.

bilalshaikh42 added a commit that referenced this issue Nov 4, 2021
@bilalshaikh42
feat(combine-api): add dynamic module for combine api-client
0c40aa6 
adds a dyamic module that selects the basepath for the combine api client based on the current
environment.

closes #3180
@bilalshaikh42 bilalshaikh42 mentioned this issue Nov 4, 2021
Merged
bilalshaikh42 added a commit that referenced this issue Nov 4, 2021
@bilalshaikh42
feat(combine-api): add dynamic module for combine api-client
4af997e 
adds a dyamic module that selects the basepath for the combine api client based on the current
environment.

closes #3180
bilalshaikh42 added a commit that referenced this issue Nov 4, 2021
@bilalshaikh42
feat(combine-api): add dynamic module for combine api-client
1e1a050 
adds a dyamic module that selects the basepath for the combine api client based o>
environment.

closes #3180
ToDo automation moved this from Needs triage to Closed Nov 4, 2021
bilalshaikh42 added a commit that referenced this issue Nov 4, 2021
@bilalshaikh42
feat(combine-api): add dynamic module for combine api-client
e7c2448 
adds a dyamic module that selects the basepath for the combine api client based o>
environment.

closes #3180
biosimulations-daemon added a commit that referenced this issue Nov 4, 2021
@biosimulations-daemon
chore(release): 6.0.0 [skip ci]
e70c296 
# [6.0.0](v5.9.0...v6.0.0) (2021-11-04)

### Bug Fixes

* **api:** build fix for new axios types ([e7ea984](e7ea984))
* **dispatch-service:** add a temporary check for mistructured logs ([a67bfa1](a67bfa1)), closes [#3482](#3482) [#3482](#3482)
* **dispatch-service:** remove ssl skip when downloading archive ([b4bd2c0](b4bd2c0)), closes [#3092](#3092)
* **dispatch,api,dispatch-service:** fixed data model for exceptions in simulation run logs ([191f1d3](191f1d3))
* fix imports ([a076005](a076005))
* **simulators:** fixed text overflow of simulator test results ([7a8b11a](7a8b11a))

### Code Refactoring

* **api:** cleaned up simulation run files ([0213fb5](0213fb5))

### Features

* added endpoints for getting summaries of projects ([2e9a54e](2e9a54e))
* **api:** added database model and validation for logs ([6a3a344](6a3a344))
* **api:** added endpoints for getting individual SED elements; closes [#3439](#3439) ([8aa64fc](8aa64fc))
* **combine-api:** add dynamic module for combine api-client ([e7c2448](e7c2448)), closes [#3180](#3180)
* **datamodel:** add validation for image digests ([6106e54](6106e54))
* **dispatch-service:** enhanced tracking of processing results ([b4f01e3](b4f01e3))
* **dispatch:** updated publication form, finished switching to Endpoints ([a5bef72](a5bef72))
* **exceptions:** improve error handling ([4a3e8c7](4a3e8c7))
* **hsds:** handle transient hsds query failures ([f4a19f5](f4a19f5)), closes [#3413](#3413)
* **ontology:** added parent/child relationships to ontology terms ([4107f1d](4107f1d))
* **simulators-api:** add validation for api models ([ce2c5bb](ce2c5bb))
* **simulators,dispatch,platform:** added status bar to bottom of apps; closes [#3210](#3210) ([3630c23](3630c23))

### Reverts

* **dispatch-service:** revert using new config service to provide basepath ([e479d2e](e479d2e))

### BREAKING CHANGES

* **api:** moves simulation run file information from 'Simulation Files' collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonrkarr jonrkarr

@bilalshaikh42 bilalshaikh42

Labels
bug Something isn't working
Projects
ToDo
Closed
Milestone
No milestone
2 participants
@jonrkarr @bilalshaikh42