Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated structured log to include more extensive message #4786

Merged
merged 8 commits into from
Jan 10, 2024

Conversation

AlexPatrie
Copy link
Collaborator

What does this PR do?:

  • Adds stepsInfo.reason to dispatch-service.submission.complete.processor.CompleteProcessor.getFailedStepErrorMessage error message for more verbose output.

Copy link

nx-cloud bot commented Jan 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8d961c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@probot-autolabeler probot-autolabeler bot added the ui label Jan 4, 2024
@AlexPatrie AlexPatrie marked this pull request as ready for review January 10, 2024 14:16
@probot-autolabeler probot-autolabeler bot added the runBiosimulations Issues pertaining to runBiosimulations frontend label Jan 10, 2024
Copy link
Collaborator

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please respond to comments

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes addressed, approved!

@AlexPatrie AlexPatrie merged commit 4a6157e into dev Jan 10, 2024
22 checks passed
@AlexPatrie AlexPatrie deleted the extend-logs branch January 10, 2024 18:07
@biosimulations-daemon
Copy link
Collaborator

🎉 This PR is included in version 9.54.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released runBiosimulations Issues pertaining to runBiosimulations frontend simulation-service ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants